Repository navigation
package.json: add express 3.x to fix docular deps - #8
Merged
Merged
Conversation
Docular specifies `express: *` as a dependency, though it does not work with express 4.x versions. By adding `express: 3.x` to our package.json, npm will use our copy of express and don't install the latest express version in docular node_modules.
|
All is well |
bajtos
added a commit
that referenced
this pull request
May 26, 2014
package.json: add express 3.x to fix docular deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docular specifies
express: *as a dependency, though it does not workwith express 4.x versions.
By adding
express: 3.xto our package.json, npm will use our copyof express and don't install the latest express version in docular
node_modules.
This patch is a workaround for Vertafore/docular#102 and can be reverted once that fix is landed.
Close #7.
/cc @ritch just FYI, I don't think there is anything to review here.