Skip to content

package.json: add express 3.x to fix docular deps - #8

Merged
bajtos merged 1 commit into
masterfrom
feature/fix-doc-on-windows
May 26, 2014
Merged

bajtos merged 1 commit into
masterfrom
feature/fix-doc-on-windows

Conversation

@bajtos

@bajtos bajtos commented May 26, 2014

Copy link
Copy Markdown
Member

Docular specifies express: * as a dependency, though it does not work
with express 4.x versions.

By adding express: 3.x to our package.json, npm will use our copy
of express and don't install the latest express version in docular
node_modules.

This patch is a workaround for Vertafore/docular#102 and can be reverted once that fix is landed.

Close #7.

/cc @ritch just FYI, I don't think there is anything to review here.

Docular specifies `express: *` as a dependency, though it does not work
with express 4.x versions.

By adding `express: 3.x` to our package.json, npm will use our copy
of express and don't install the latest express version in docular
node_modules.
@slnode

slnode commented May 26, 2014

Copy link
Copy Markdown

All is well
Refer to this link for build results: http://ci.strongloop.com/job/loopback-angular-cli/508/

bajtos added a commit that referenced this pull request May 26, 2014
package.json: add express 3.x to fix docular deps
@bajtos
bajtos merged commit 53ebea9 into master May 26, 2014
@bajtos
bajtos deleted the feature/fix-doc-on-windows branch May 26, 2014 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lb-ng-doc can't find config module

2 participants